RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v2]
Marius Hanl
mhanl at openjdk.org
Thu Jan 16 16:04:17 UTC 2025
On Thu, 16 Jan 2025 12:26:19 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> This is more likely an 'accidential' fix. I changed this code because the code in the super class changed (e.g. `updateCells` and `updateChildren`). So while I see your point, if possible I would not try to cherrypick this out (if even possible) and keep it in here.
>> Good point, I will check if I can write a test for it.
>
> EDIT: The issue is about the `TreeView` specifically, so this code is not related to the issue (it is in `TreeTableRowSkin`).
> The fix is in the `VirtualFlow`, which I did for the table virtualization (issues), but that also fixes the issue for the `TreeView` as well.
EDIT2: I wrote a test, that fails before and succeeds after for that specific problem!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1918811739
More information about the openjfx-dev
mailing list