RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v2]

[Andy Goryachev]

On Wed, 15 Jan 2025 19:22:50 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Marius Hanl has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 221:
> 
>> 219:     /** {@inheritDoc} */
>> 220:     @Override protected void layoutChildren(double x, double y, double w, double h) {
>> 221:         Node disclosureNode = getDisclosureNode();
> 
> I take these changes (related to disclosure node) are not really related to the initial issue of this PR, and I wonder if [JDK-8346824](https://bugs.openjdk.org/browse/JDK-8346824) should not be part of this PR. Do the added tests verify these changes and if the issue is solved with them?

I second @jperedadnr concern about combining separate issues into one PR.  Small focused PRs will get tested, reviewed, and integrated almost always faster than the big complicated ones.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1919120797