RFR: 8345261: Refactor the Dimension2D classes

Nir Lisker nlisker at openjdk.org
Sat Jan 25 07:04:41 UTC 2025


On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Thanks @azvegint. If the `int`-based dimensions are coupled with `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place they are used at), would you object to making `Dimension` an inner class of `Rectangle`? The `float`-based dimensions are used in other 2D shapes, so are more general purpose.
>
>> would you object to making Dimension an inner class of Rectangle?
> 
> I am fine with it.

@azvegint Please confirm that the change is acceptable.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2613817033


More information about the openjfx-dev mailing list