RFR: 8314482: TextFlow: TabStopPolicy [v2]
Andy Goryachev
angorya at openjdk.org
Wed Jul 9 15:32:45 UTC 2025
On Tue, 8 Jul 2025 23:11:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Not sure if defaultTabWidth is a good choice here though, because it's not, it's actually tab stops - think of the typewriter (I know, referring to an ancient technology like floppy disk for the 'save' icon does not age well)
>>
>> I am open to suggestions. I am used to "default tab stops", perhaps we could just explain it better?
>
> Getting back to this, there are two naming questions here. First, should "tab" be in the name (it does seem a bit redundant, since the name of the class is TabStopPolicy)? Second, what is the best name for the value that defines a repeating set of stops?
>
> If we drop the word "tab" the list of tab stops would just be named "stops", which seems fine. Here are some possible names for the default:
>
> - defaultStop
> - defaultStops
> - defaultStopInterval
> - Something Else?
>
> I kind of like the last of these, `defaultStopInterval`, as it is the most descriptive. Whatever we do will need to be documented well.
ooh, I like `defaultStopInterval`, thank you.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2195324654
More information about the openjfx-dev
mailing list