RFR: 8314482: TextFlow: TabStopPolicy [v2]
Michael Strauß
mstrauss at openjdk.org
Wed Jul 9 17:26:44 UTC 2025
On Wed, 9 Jul 2025 15:29:50 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Getting back to this, there are two naming questions here. First, should "tab" be in the name (it does seem a bit redundant, since the name of the class is TabStopPolicy)? Second, what is the best name for the value that defines a repeating set of stops?
>>
>> If we drop the word "tab" the list of tab stops would just be named "stops", which seems fine. Here are some possible names for the default:
>>
>> - defaultStop
>> - defaultStops
>> - defaultStopInterval
>> - Something Else?
>>
>> I kind of like the last of these, `defaultStopInterval`, as it is the most descriptive. Whatever we do will need to be documented well.
>
> ooh, I like `defaultStopInterval`, thank you.
Maybe make it even shorter and do `TabStopPolicy.defaultInterval`. The reasoning for dropping the "stop" is the same as before, it's already the class name.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2195577224
More information about the openjfx-dev
mailing list