RFR: 8313424: JavaFX controls in the title bar (Preview) [v78]

[Kevin Rushforth]

On Tue, 3 Jun 2025 19:13:08 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Implementation of [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix memory leak in ViewScene

I finished my review of the API. It looks good. I identified one minor formatting issue in the docs.

I also left a minor question about a test method. I'll review the CSR and do a bit of light testing. Others have reviewed the implementation, so I'll limit most of my code review to the native glass changes.

modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 63:

> 61:      * This method is only used for testing purposes.
> 62:      */
> 63:     public static void enableForTesting() {

Minor: As an alternative, have you considered adding a utility method in a test utility class that sets both the `javafx.enablePreview` and `javafx.suppressPreviewWarning` system properties? Unless there a reason that wouldn't work, it seems cleaner to me.

modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 254:

> 252:      * use custom header buttons instead (see {@link #setButtonType(Node, HeaderButtonType)}).
> 253:      * <p>
> 254:      * The default value {@code #USE_DEFAULT_SIZE} indicates that the platform should choose the button height.

Minor: The `#` is rendered since it using `@code` rather than `@link`. I recommend removing the `#`.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1605#pullrequestreview-2894405127
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2125132948
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2126483269