RFR: 8313424: JavaFX controls in the title bar (Preview) [v78]

[Michael Strauß]

On Tue, 3 Jun 2025 23:48:33 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix memory leak in ViewScene
>
> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 63:
> 
>> 61:      * This method is only used for testing purposes.
>> 62:      */
>> 63:     public static void enableForTesting() {
> 
> Minor: As an alternative, have you considered adding a utility method in a test utility class that sets both the `javafx.enablePreview` and `javafx.suppressPreviewWarning` system properties? Unless there a reason that wouldn't work, it seems cleaner to me.

I've modified the build script instead to always specify the system properties for tests.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2126794640