RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]
Michael Strauß
mstrauss at openjdk.org
Mon Mar 10 09:35:10 UTC 2025
On Mon, 10 Mar 2025 02:06:11 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManager.java line 45:
>
>> 43: * a {@link ListenerList}. It is recommended to never inspect this field directly
>> 44: * but always use this manager to interact with it.
>> 45: *
>
> I suggest adding a line that says that this class is used by bindings.
I think we shouldn't document obvious things as that's very little added value. Any IDE can show you where the class is used.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1986920125
More information about the openjfx-dev
mailing list