RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

Nir Lisker nlisker at openjdk.org
Wed Mar 12 00:38:13 UTC 2025


On Sun, 9 Mar 2025 23:05:02 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerManager.java line 168:
> 
>> 166:      *   can be {@code null} which means there are no listeners to notify
>> 167:      */
>> 168:     public void fireValueChanged(I instance, Object listenerData) {
> 
> Same comments. `null` check on `instance`?

Is a switch expression on `listenerData` not suitable here?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1990350890


More information about the openjfx-dev mailing list