RFR: 8342565: [TestBug] StubTextLayout [v9]

Kevin Rushforth kcr at openjdk.org
Tue Mar 25 22:11:24 UTC 2025


On Tue, 25 Mar 2025 21:46:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line 45:
>> 
>>> 43:     int script;
>>> 44:     TextSpan span;
>>> 45:     com.sun.javafx.scene.text.TextLine line;
>> 
>> I recommend an import rather than listing the fully-qualified class here and below.
>
> the problem is that we have `com.sun.javafx.text.TextLine implements com.sun.javafx.scene.text.TextLine`
> 
> we probably should rename the concrete class to something like `PrismTextLine` for clarity, but that will create a much larger diff.

Yes, that might be a good cleanup task on its own, but best to leave it alone for this PR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1667#discussion_r2013003349


More information about the openjfx-dev mailing list