RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v2]

[Ziad El Midaoui]

On Mon, 5 May 2025 14:46:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Created ModenaTest
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTest.java line 23:
> 
>> 21: import static org.junit.jupiter.api.Assertions.fail;
>> 22: 
>> 23: public class ModenaTest {
> 
> perhaps add a javadoc describing what this file is supposed to test?

I did add it

> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTest.java line 33:
> 
>> 31:     }
>> 32: 
>> 33:     private TextInputControl textInput;
> 
> Since this test tests `modena.css` aspects of the `TextInputControl` class hierarchy, should this test be renamed then (`TextInputControlModena` or something like that)?

Yes found that more convenient and changed the name to TextInputControlModena, we can use this class to test modena.css for `TextInputControl`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1801#discussion_r2073877269
PR Review Comment: https://git.openjdk.org/jfx/pull/1801#discussion_r2073876319