RFR: 8356652: Input field ignores custom input source characters [v2]

[Martin Fox]

On Fri, 16 May 2025 23:13:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Second try at making Keyman work to some extent
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 806:
> 
>> 804:     // but a text input client should not. So we ignore this which avoids an
>> 805:     // annoying beep.
>> 806:     if (keymanActive) {
> 
> I noticed the latest code does not beep.  Were the beeps produced earlier expected for unmapped keys?

I'm not sure where the beeps are coming from. I still hear a beep when I press N on the Himyarit Musnad layout but I don't hear a beep when I press X on the ISIS-Devanagari layout. Both are unused keys but one produces a beep and the other doesn't.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1805#discussion_r2093787087