RFR: 8371052: Update libFFI to 3.5.2
Ambarish Rapte
arapte at openjdk.org
Thu Nov 6 11:33:22 UTC 2025
On Wed, 5 Nov 2025 02:17:39 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - Updated libFFI to 3.5.2.
> - Tested on all platforms.
> - No additional changes are done.
Spot checked files.
I have provided a query and a minor suggestion. Please check. rest LGTM.
modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffi_cfi.h line 74:
> 72: # define cfi_lsda(enc, exp)
> 73: # define cfi_escape(...)
> 74: # define cfi_window_save
The libffi 3.5.2 source contains a definition of `cfi_window_save` under `#ifdef HAVE_AS_CFI_PSEUDO_OP` as well. Could you please check.
modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/aarch64/internal.h line 93:
> 91: #define SIGN_LR_LINUX_ONLY
> 92: #define BRANCH_TO_REG braaz
> 93: #define PAC_CFI_WINDOW_SAVE
Minor:
Looks like the upstream libffi file has some specific space additions in this file to showcase nesting. So, to match it, Line 86 to 90, line 92, should also be modified to have prefixing space.
Similar applies to line 135 to 142.
It may help reducing conflicts during next update.
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1962#pullrequestreview-3427532447
PR Review Comment: https://git.openjdk.org/jfx/pull/1962#discussion_r2498482768
PR Review Comment: https://git.openjdk.org/jfx/pull/1962#discussion_r2498582602
More information about the openjfx-dev
mailing list