RFR: 8371052: Update libFFI to 3.5.2
Alexander Matveev
almatvee at openjdk.org
Thu Nov 6 23:35:18 UTC 2025
On Thu, 6 Nov 2025 10:52:40 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> - Updated libFFI to 3.5.2.
>> - Tested on all platforms.
>> - No additional changes are done.
>
> modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffi_cfi.h line 74:
>
>> 72: # define cfi_lsda(enc, exp)
>> 73: # define cfi_escape(...)
>> 74: # define cfi_window_save
>
> The libffi 3.5.2 source contains a definition of `cfi_window_save` under `#ifdef HAVE_AS_CFI_PSEUDO_OP` as well. Could you please check.
This is how it is done in the original code. Two repeated definitions:
`# define cfi_window_save .cfi_window_save` under `#ifdef HAVE_AS_CFI_PSEUDO_OP` and `# define cfi_window_save` otherwise. I was missing repeated `# define cfi_window_save .cfi_window_save`. I will add it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1962#discussion_r2501210704
More information about the openjfx-dev
mailing list