RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Andy Goryachev
angorya at openjdk.org
Mon Nov 17 23:48:33 UTC 2025
On Sun, 24 Aug 2025 20:39:46 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - review comments 2
>> - review comments 1
>
> modules/javafx.base/src/main/java/javafx/util/converter/BaseTemporalStringConverter.java line 86:
>
>> 84: .withChronology(chrono)
>> 85: .withDecimalStyle(DecimalStyle.of(locale));
>> 86: }
>
> Weird level of indent, perhaps use 4 or 8?
why 8?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2535721058
More information about the openjfx-dev
mailing list