RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Nov 18 00:04:03 UTC 2025
On Mon, 17 Nov 2025 22:34:03 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - review comments 2
>> - review comments 1
>
> modules/javafx.base/src/main/java/javafx/util/converter/BaseStringConverter.java line 30:
>
>> 28: import javafx.util.StringConverter;
>> 29:
>> 30: /// A base class containing common implementations for `StringConverter`s as noted in the @implNote of `StringConverter`.
>
> In light of possible backporting, it's been decided earlier not to use markdown comments.
In general, yes, but I note that this is a pretty major refactoring where most of the javadocs were redone, and all of them now use markdown. This is a case where we could consider allowing them. I don't have a strong opinion either way, and likely won't have time to review this one for a while...
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2535870408
More information about the openjfx-dev
mailing list