RFR: 8370446: Support dialogs with StageStyle.EXTENDED (Preview) [v6]
Andy Goryachev
angorya at openjdk.org
Tue Nov 18 18:07:17 UTC 2025
On Tue, 18 Nov 2025 16:49:07 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Adds the `DialogPane.headerBar` property, which allows developers to specify a custom `HeaderBar` when the dialog uses the `EXTENDED` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> skip preview feature check for internal use
Marked as reviewed by angorya (Reviewer).
modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java line 506:
> 504: }
> 505:
> 506: // This method skips the preview feature check for internal use and can be removed when HeaderBar is finalized.
I wonder if a comment should be added to the JBS ticket listing the things that need to be undone, lest we forget.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1943#pullrequestreview-3479103169
PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2539193935
More information about the openjfx-dev
mailing list