RFR: 8370446: Support dialogs with StageStyle.EXTENDED (Preview) [v6]
Michael Strauß
mstrauss at openjdk.org
Tue Nov 18 18:36:40 UTC 2025
On Tue, 18 Nov 2025 18:03:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> skip preview feature check for internal use
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java line 506:
>
>> 504: }
>> 505:
>> 506: // This method skips the preview feature check for internal use and can be removed when HeaderBar is finalized.
>
> I wonder if a comment should be added to the JBS ticket listing the things that need to be undone, lest we forget.
In this specific case it's quite hard to miss, since it's right next to the preview API. But go ahead if you want to add the comment.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2539273108
More information about the openjfx-dev
mailing list