RFR: 8250802: Refactor StringConverter and its subclasses [v2]

Andy Goryachev angorya at openjdk.org
Wed Nov 19 15:41:13 UTC 2025


On Wed, 19 Nov 2025 00:38:43 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java line 115:
>> 
>>> 113:                 getSpecialziedDateFormat(dateStyle, timeStyle, locale) :
>>> 114:                 new SimpleDateFormat(pattern, locale);
>>> 115:         dateFormat.setLenient(false);
>> 
>> Would setting `lenient=false` constitute a change in functionality?
>
> Why would it? It was the same before this change?

Not exactly, if I read it right.
The lenient flag is not set if the format is specified in the constructor - see L204 in the original class.  The new code clears this flag regardless.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2542558215


More information about the openjfx-dev mailing list