RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Nir Lisker
nlisker at openjdk.org
Wed Nov 19 00:41:14 UTC 2025
On Mon, 17 Nov 2025 22:49:26 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - review comments 2
>> - review comments 1
>
> modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java line 115:
>
>> 113: getSpecialziedDateFormat(dateStyle, timeStyle, locale) :
>> 114: new SimpleDateFormat(pattern, locale);
>> 115: dateFormat.setLenient(false);
>
> Would setting `lenient=false` constitute a change in functionality?
Why would it? It was the same before this change?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2540055853
More information about the openjfx-dev
mailing list