RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells [v3]
Andy Goryachev
angorya at openjdk.org
Wed Oct 15 15:25:13 UTC 2025
On Wed, 15 Oct 2025 13:55:41 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>>> In fact, the public method in this Control is the normative one, so it must define the expected behavior for all the implementors to follow.
>>
>> You're absolutely right.
>
>> And what if the control uses a custom skin that is not based on the `VirtualFlow`?
>
> But that can also be used against using the description from `VirtualFlow`. Right now, I would insist to not add any more details, as the rebuild implementation may change later on.
>
> Right now, we remove and add them to the viewport, but this is not really needed. What we want to achieve is that `updateItem` is called, and this way ensures that. But there are other, better and faster ways to do so. Something I might revisit at one point in the future.
>
> And since the `In other words` explains why this useful, I think we are good here.
I still don't know what "rebuild" means in this context.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1830#discussion_r2433003265
More information about the openjfx-dev
mailing list