RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v50]

Thiago Milczarek Sayao tsayao at openjdk.org
Thu Sep 18 09:48:37 UTC 2025


On Fri, 22 Aug 2025 21:05:05 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> I think you use assumeTrue to check whether the test should proceed. So you want `assumeTrue(!PlatformUtil.isWindows())` or `assumeFalse(PlatformUtil.isWindows())`.
>
> I always get confused by this. Will fix it.

Fixed

>> Since it picks up a random color it could get a match by accident. Highly unlikely but possible. Though I see what you're saying, any time we use a robot to sample a pixel we could get the expected color by chance because it just happens to be in the desktop image.
>
> Good point, I'll fix it.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2358255540
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2358259237


More information about the openjfx-dev mailing list