RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v50]
Thiago Milczarek Sayao
tsayao at openjdk.org
Thu Sep 18 09:48:36 UTC 2025
On Fri, 22 Aug 2025 21:32:12 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> The test still looks incorrect. You're passing in posX and posY as the tolerance deltas.
>>
>> I'm not sure what you're testing here. There's an internal algorithm that sets the window's x and y coordinate to center it. You're replicating that algorithm here and testing whether the window has the same x and y values. If you're concerned that the platform code didn't actually move the window you would need to use a robot to sample a pixel and verify that the window is where you expect. Or was there some other centering problem you saw on Linux?
>
> On Linux, when frame extents are received (and it might arrive later depending on the compositor / window manager), it must do a correction on the centering accounting the decorations (glass_window.cpp around line 895). This was the idea behind the test, but I think I "over tested" and this is really not useful. Will remove it.
Test removed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2358256386
More information about the openjfx-dev
mailing list