RFR: 8357625: Build should generate platform specific shaders [v3]

Andy Goryachev angorya at openjdk.org
Tue Feb 17 16:13:23 UTC 2026


On Mon, 16 Feb 2026 14:54:56 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> On a given platform, the build generates prism and decora shader files for all platforms. 
>> Ideally it should generate only the platform specific shader files.
>> 
>> Fix:
>> Generate only platform specific hardware shaders.
>> sw pipeline shaders must be generated for all platforms.
>> 
>> But the hardware shaders, should be as:
>> 1. Mac platform : metal and es2 shaders
>> 2. Win platform: d3d shaders and if IS_INCLUDE_ES2 is true then es2 shaders as well
>> 3. Linux : only es2 shaders
>> 
>> Verification:
>> Verified that the shaders are generated as expected. 
>> headul tests pass, apps launch correctly.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> 
>   avoid Decora and Prism dir, under javafx.graphics/build/hlsl

build.gradle line 2785:

> 2783:     task initShaderDirs() {
> 2784:         doLast {
> 2785:             if (IS_WINDOWS) {

I suggest we create the directories all the time (I don't see any harm in having empty directories).  Otherwise, we'd need to make Eclipse config files platform specific, and I don't know how to do it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2071#discussion_r2817856960


More information about the openjfx-dev mailing list