RFR: 8357625: Build should generate platform specific shaders [v3]

Andy Goryachev angorya at openjdk.org
Tue Feb 17 18:06:50 UTC 2026


On Tue, 17 Feb 2026 16:11:12 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   avoid Decora and Prism dir, under javafx.graphics/build/hlsl
>
> build.gradle line 2785:
> 
>> 2783:     task initShaderDirs() {
>> 2784:         doLast {
>> 2785:             if (IS_WINDOWS) {
> 
> I suggest we create the directories all the time (I don't see any harm in having empty directories).  Otherwise, we'd need to make Eclipse config files platform specific, and I don't know how to do it.

In fact, I would like a comment added here saying something like

`do not introduce platform-specific logic here for the sake of third party tools (Eclipse)`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2071#discussion_r2818359690


More information about the openjfx-dev mailing list