RFR: 8357625: Build should generate platform specific shaders [v3]

[Nir Lisker]

On Mon, 16 Feb 2026 14:54:56 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> On a given platform, the build generates prism and decora shader files for all platforms. 
>> Ideally it should generate only the platform specific shader files.
>> 
>> Fix:
>> Generate only platform specific hardware shaders.
>> sw pipeline shaders must be generated for all platforms.
>> 
>> But the hardware shaders, should be as:
>> 1. Mac platform : metal and es2 shaders
>> 2. Win platform: d3d shaders and if IS_INCLUDE_ES2 is true then es2 shaders as well
>> 3. Linux : only es2 shaders
>> 
>> Verification:
>> Verified that the shaders are generated as expected. 
>> headul tests pass, apps launch correctly.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> 
>   avoid Decora and Prism dir, under javafx.graphics/build/hlsl

> > but doesn't marking them as optional solve this?
> 
> Off-topic, but I would prefer an empty "Problems" view, so any problem that is a real problem is immediately apparent (even more important for code reviews). I know some people are comfortable with having all the warnings on, but I think it is counter-productive.
> 
> <img alt="Screenshot 2026-02-17 at 08 44 15" width="395" height="176" src="https://private-user-images.githubusercontent.com/107069028/551085532-e4271fbd-3907-4f22-afe3-174f03e38864.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzEzNTU2MjMsIm5iZiI6MTc3MTM1NTMyMywicGF0aCI6Ii8xMDcwNjkwMjgvNTUxMDg1NTMyLWU0MjcxZmJkLTM5MDctNGYyMi1hZmUzLTE3NGYwM2UzODg2NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIxN1QxOTA4NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00ZmNhODI4YmRkYTdjOTQ5NTU2ZmQzNzZjODQxOTZmNjIwNjcwMzJjYzM3YThmZTIyNGYyYjhiZDU1ZTE3ZTk3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.TXIQ9gHdJFCPV1uXDAD5uFXyL7CnlXo15cHqmHiezXk">

I don't remember getting a warning for missing optional dependencies. Could be some setting. Anyway, having empty dirs solves it in an acceptable way.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2071#issuecomment-3916612386