Vector API testing infrastructure

Halimi, Jean-Philippe jean-philippe.halimi at intel.com
Thu Feb 8 22:06:55 UTC 2018


Thanks a lot for your feedback.

I agree with all of your points so far. I will work on that in the coming days.

Thanks to Razvan and Vivek's help, I published a new follow-up patch adding generated tests.

http://cr.openjdk.java.net/~rlupusoru/panama/webrev_vector_api_test_infra_01/

Cheers,

Jp

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Thursday, February 8, 2018 1:38 PM
To: Halimi, Jean-Philippe <jean-philippe.halimi at intel.com>; panama-dev at openjdk.java.net
Cc: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
Subject: Re: Vector API testing infrastructure

Nice work, Jp! Looks very good!

> It will be helpful to include the generated test cases as well.

I second that. Please, add generated test cases as well.

Some other comments:

   * testng in test path is useless

Do you see any problems with putting files right into test/jdk/jdk/incubator/vector/?

   * In the longer term, there should be only 1 script left: the one which generates test sources from templates.

Best regards,
Vladimir Ivanov

> -----Original Message-----
> From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On 
> Behalf Of Halimi, Jean-Philippe
> Sent: Thursday, February 08, 2018 10:52 AM
> To: panama-dev at openjdk.java.net
> Subject: Vector API testing infrastructure
> 
> Hi,
> 
> I am a new contributor to this list. I am contributing Vector API testing framework. Please have a look at the webrev below to learn more about it. It features a README file in case you want to generate, build and run the tests.
> The generated source code is not part of the initial commit, but they can be added if need be.
> 
> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_vector_api_test_in
> fra_00/
> 
> Cheers,
> 
> Jp
> 


More information about the panama-dev mailing list