Vector API testing infrastructure

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Thu Feb 8 22:17:16 UTC 2018


> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_vector_api_test_infra_01/

Looks good.

Suggestions for followup improvements:


test/jdk/jdk/incubator/vector/testng/Byte128VectorTests.java:

   33 public class Byte128VectorTests {
   34     static final int SIZE = 128 * 1000;
   35     static final ByteVector.ByteSpecies<Shapes.S128Bit> species = 
(ByteVector.ByteSpecies<Shapes.S128Bit>)
   36                 Vector.speciesInstance(Byte.class, Shapes.S_128_BIT);


test/jdk/jdk/incubator/vector/testng/Byte256VectorTests.java

   33 public class Byte256VectorTests {
   34     static final int SIZE = 256 * 1000;
   35     static final ByteVector.ByteSpecies<Shapes.S256Bit> species = 
(ByteVector.ByteSpecies<Shapes.S256Bit>)
   36                 Vector.speciesInstance(Byte.class, Shapes.S_256_BIT);

You can have a single test per element type parameterized by vector 
size. The size can be controlled from command-line (either by argument 
or system property). Then having multiple @run commands enumerating all 
implemented sizes.

Best regards,
Vladimir Ivanov

> 
> Cheers,
> 
> Jp
> 
> -----Original Message-----
> From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com]
> Sent: Thursday, February 8, 2018 1:38 PM
> To: Halimi, Jean-Philippe <jean-philippe.halimi at intel.com>; panama-dev at openjdk.java.net
> Cc: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
> Subject: Re: Vector API testing infrastructure
> 
> Nice work, Jp! Looks very good!
> 
>> It will be helpful to include the generated test cases as well.
> 
> I second that. Please, add generated test cases as well.
> 
> Some other comments:
> 
>     * testng in test path is useless
> 
> Do you see any problems with putting files right into test/jdk/jdk/incubator/vector/?
> 
>     * In the longer term, there should be only 1 script left: the one which generates test sources from templates.
> 
> Best regards,
> Vladimir Ivanov
> 
>> -----Original Message-----
>> From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On
>> Behalf Of Halimi, Jean-Philippe
>> Sent: Thursday, February 08, 2018 10:52 AM
>> To: panama-dev at openjdk.java.net
>> Subject: Vector API testing infrastructure
>>
>> Hi,
>>
>> I am a new contributor to this list. I am contributing Vector API testing framework. Please have a look at the webrev below to learn more about it. It features a README file in case you want to generate, build and run the tests.
>> The generated source code is not part of the initial commit, but they can be added if need be.
>>
>> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_vector_api_test_in
>> fra_00/
>>
>> Cheers,
>>
>> Jp
>>


More information about the panama-dev mailing list