[vector] Unary/Ternary ops

Paul Sandoz paul.sandoz at oracle.com
Wed Feb 14 18:26:52 UTC 2018



> On Feb 14, 2018, at 10:12 AM, Al K <someusername3 at gmail.com> wrote:
> 
> Oops, wrong patch link, see
> http://cr.openjdk.java.net/~vlivanov/panama/al_miftah/vector_ops/webrev.00/index.html
> 

One comment:

- For fma I recommend creating a package private TriFunction rather than packing into an array, then i think the additional casts will be redundant.

Thanks, 
Paul.

> On Wed, Feb 14, 2018 at 11:54 AM, Al K <someusername3 at gmail.com> wrote:
> 
>> http://cr.openjdk.java.net/~vlivanov/panama/vector.generalized_intrinsics/webrev.06/
>> 
>> 
>> This extends the generalized intrinsics changeset with the following:
>> 
>> 1. General ternary ops - currently only fma
>> 
>> 2. General unary ops - abs/neg/sqrt
>> 
>> 
>> I've replaced the previous inline_vector_binary_operation() in opto/library_call
>> 
>> with a generic inline_vector_nary_operation() to avoid writing specialized impls
>> 
>> for the various n-ary ops.
>> 
>> 
>> There's also a change in os/linux/os_linux to fix the pointer comparison so clang
>> 
>> would stop complaining.
>> 
>> 
>> I've signed the OCA, awaiting for it to be reflected on the site.
>> 
>> 
>> Cheers,
>> 
>> Al
>> 
>> 



More information about the panama-dev mailing list