[foreign] RFR 8219230: Struct.toString implementation is outdated

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Feb 18 13:07:07 UTC 2019


Looks good

-Sundar

On 18/02/19, 6:28 PM, Jorn Vernee wrote:
> Hi,
>
> After moving to method level @NativeGetter annotations the 
> implementation of Struct.toString was not updated for the new scheme. 
> I've update the implementation, and added a test. I reused the 
> Struct.OffsetOf test class and renamed it to StructTest. I've also 
> added as Struct.sizeOf test to the same class for good measure.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8219230
> Webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8219230/webrev.00/
>
> Thanks,
> Jorn


More information about the panama-dev mailing list