[foreign] RFR 8219230: Struct.toString implementation is outdated

[Jorn Vernee]

Thanks.

I think the weird diff is an artifact from having rename + changes to 
the same file. FWIW, the line endings are no different from the other 
test files I have (all CRLF, which I guess gets converted automatically)

Jorn

Maurizio Cimadamore schreef op 2019-02-18 14:03:
> Looks good - there's something odd with line terminators on the test 
> changes.
> 
> Maurizio
> 
> On 18/02/2019 12:58, Jorn Vernee wrote:
>> Hi,
>> 
>> After moving to method level @NativeGetter annotations the 
>> implementation of Struct.toString was not updated for the new scheme. 
>> I've update the implementation, and added a test. I reused the 
>> Struct.OffsetOf test class and renamed it to StructTest. I've also 
>> added as Struct.sizeOf test to the same class for good measure.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219230
>> Webrev: 
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8219230/webrev.00/
>> 
>> Thanks,
>> Jorn