[foreign] RFR 8221177: Jextract should levarage file system specific path constraints when matching header paths

[Maurizio Cimadamore]

Looks good!

Sure, go ahead and normalize all newlines.

Maurizio

On 21/03/2019 15:52, Jorn Vernee wrote:
> I went with asPathPredicates.
>
> The line endings were a bigger problem. I thought the repo settings 
> made sure that Unix line endings were used, but it seems that's 
> something done by jcheck which we don't use. The OpenJDK style guide 
> dictates use of Unix line endings [1], so I've gone ahead and changed 
> all the line endings to Unix (LF) for the files that I've created in 
> the past. I've also set IntelliJ to force Unix line endings, so this 
> should (hopefully) not be a problem in the future.
>
> Updated webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/caps/webrev.01/
>
> The other line ending changes didn't show up in the webrev, but I 
> could include them when pushing?
>
> Cheers,
> Jorn
>
> [1] : 
> https://wiki.openjdk.java.net/display/OpenJFX/Code+Style+Rules#CodeStyleRules-Whitespace
>
> Sundararajan Athijegannathan schreef op 2019-03-21 02:42:
>> +1
>>
>> If you want fullname, shouldn't it be asPathMatchPredicates?
>>
>> PS. Noticed that weird newlines in webrev in one of the files I
>> modified (in another patch) as well. But it shows fine in the source -
>> no extra newline there..
>>
>> -Sundar
>>
>> On 21/03/19, 5:25 AM, Maurizio Cimadamore wrote:
>>> Looks good - couple of nits:
>>>
>>> * I find 'asPathmatchPredicates' a bit of a mouthful :-), maybe drop 
>>> the 'match' ?
>>>
>>> * there seem to be weird newlines both in Filters.java and 
>>> PatternFilter.java  - probably Windows-related?
>>>
>>> Maurizio
>>>
>>> On 20/03/2019 22:09, Jorn Vernee wrote:
>>>> Hi,
>>>>
>>>> This is an RFR for earlier discussed changes for file system 
>>>> specific path matching: 
>>>> https://mail.openjdk.java.net/pipermail/panama-dev/2019-March/004975.html
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221177
>>>> Webrev: 
>>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/caps/webrev.00/
>>>>
>>>> Thanks,
>>>> Jorn