[foreign] RFR: 8223808: initial port for AArch64
Jorn Vernee
jbvernee at xs4all.nl
Tue May 28 09:19:53 UTC 2019
Hi Nick,
I'm testing the patch, and there was 1 test failure; I noticed that you
changed the code in UniversalUpcallHandler from depending on
SharedUtils.VECTOR_REGISTER_SIZE to storage.getSize(). I understand why
the change is needed, but this should use getMaxSize(), since getSize()
can be smaller. After making that change all tests pass on my machine.
The rest of the code looks good to me.
Cheers,
Jorn
Nick Gasson schreef op 2019-05-28 09:34:
> Hi all,
>
> I've put an updated webrev for the AArch64 port here:
>
> http://cr.openjdk.java.net/~ngasson/foreign/8223808/webrev.2/
>
> This contains all the previous changes plus a few fixes to handle
> things
> like "heterogeneous float aggregates" (structs/arrays where all the
> members are float/double), which are handled specially in the ABI.
>
> With this patch all the tests in the jdk_foreign group pass on AArch64,
> except the two I disabled pending adding long double support.
>
> Please let me know if you have any feedback!
>
> Thanks,
> Nick
More information about the panama-dev
mailing list