[foreign] RFR: 8223808: initial port for AArch64

[Nick Gasson]

Hi Jorn,

I'll do the SCHAR / final change in a separate patch as you and Maurizio 
already tested webrev.3. My colleague Ningsheng helped me push it.

Thanks!
Nick


On 29/05/2019 18:47, Jorn Vernee wrote:
> But, I realize this is out of scope for this RFR, so we can take care of 
> it separately as well :)
> 
> FWIW, all tests pass on my end with v3.
> 
> Jorn
> 
> Jorn Vernee schreef op 2019-05-29 11:53:
>> Also, if you're touching that file any ways. I think it's good to make
>> all the constants `final`.
>>
>> Jorn
>>
>> Maurizio Cimadamore schreef op 2019-05-29 11:38:
>>> Looks good - as for SCHAR, yes, we can go for it - and add it across
>>> the board (e.g. in all ABIs).
>>>
>>> Thanks
>>> Maurizio
>>>
>>> On 29/05/2019 08:00, Nick Gasson wrote:
>>>> Hi Maurizio,
>>>>
>>>> On 28/05/2019 19:25, Maurizio Cimadamore wrote:
>>>>> Actually, a cleaner way to get there is:
>>>>>
>>>>> public static LayoutType<Short> SHORT = 
>>>>> pick(LittleEndian.SysVABI.SHORT, LittleEndian.WinABI.SHORT, 
>>>>> LittleEndian.AArch64.SHORT);
>>>>>
>>>>> and then define the logic inside pick() to select the right value 
>>>>> depending on platform/os.
>>>>>
>>>>
>>>> Yes this is much better. I've done this in webrev.3 here:
>>>>
>>>> http://cr.openjdk.java.net/~ngasson/foreign/8223808/webrev.3/
>>>>
>>>> I added NativeTypes.AArch64ABI which differs from SysVABI in that 
>>>> long double is 128 bits and char is unsigned. I wonder if we should 
>>>> add a "SCHAR" signed char type to NativeTypes? As currently we have 
>>>> CHAR and UCHAR which are both unsigned on AArch64.
>>>>
>>>> Also fixed the x86 regression found by Jorn and re-enabled the 
>>>> UnalignedStructTest test.
>>>>
>>>> Thanks,
>>>> Nick