[foreign-jextract] RFR: 8257892: long double not handled by jextract [v2]

[Jorn Vernee]

On Tue, 8 Dec 2020 13:51:42 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> added UnsupportedLayouts and checking/warning all unsupported types uniformly
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   missed checking CHAR16 in UnsupportedLayouts.

src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/UnsupportedLayouts.java line 51:

> 49: 
> 50:     public static final ValueLayout WCHAT_T = MemoryLayout.ofValueBits(16, ByteOrder.nativeOrder()).
> 51:             withName("wchar_t").withAttribute(CLinker.TypeKind.ATTR_NAME, CLinker.TypeKind.SHORT);

Why do these need to have TypeKind attributes?

src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/UnsupportedLayouts.java line 50:

> 48:             withName("char16").withAttribute(CLinker.TypeKind.ATTR_NAME, CLinker.TypeKind.SHORT);
> 49: 
> 50:     public static final ValueLayout WCHAT_T = MemoryLayout.ofValueBits(16, ByteOrder.nativeOrder()).

Typo
Suggestion:

    public static final ValueLayout WCHAR_T = MemoryLayout.ofValueBits(16, ByteOrder.nativeOrder()).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/409