[foreign-jextract] RFR: 8257892: long double not handled by jextract [v2]

Jorn Vernee jvernee at openjdk.java.net
Wed Dec 9 15:51:50 UTC 2020


On Tue, 8 Dec 2020 17:40:41 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   missed checking CHAR16 in UnsupportedLayouts.
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/UnsupportedLayouts.java line 50:
> 
>> 48:             withName("char16").withAttribute(CLinker.TypeKind.ATTR_NAME, CLinker.TypeKind.SHORT);
>> 49: 
>> 50:     public static final ValueLayout WCHAT_T = MemoryLayout.ofValueBits(16, ByteOrder.nativeOrder()).
> 
> Typo
> Suggestion:
> 
>     public static final ValueLayout WCHAR_T = MemoryLayout.ofValueBits(16, ByteOrder.nativeOrder()).

Still a typo here. Other than that looks good.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/409


More information about the panama-dev mailing list