[foreign-jextract] [Rev 02] RFR: 8239128: Macro defines constant pointers can crash VM via jextract API
Henry Jen
henryjen at openjdk.java.net
Fri Feb 21 16:52:49 UTC 2020
> The fundamental issue of the crash is that clang cursor/type may no longer valid after reparse another macro, and with pointer type lazily resolve the pointee type, if the clang cursor/type no longer valid, access invalid memory cause the crash.
>
> The other issue is the a macro pointer to a record type like struct/union can cause NPE, and that cause the macro to be ignored on generation without a warning.
>
> The fix remove the laziness from Type API perspective, but leave that as an implementation detail, so implementation of Pointer type need to figure out how to do that safely internally.
>
> Record type in macro are reduces to void, as currently the Declaration implementation is depending on clang as well, we cannot guarantee that works after reparse.
The pull request has been updated with 1 additional commit.
-------------
Added commits:
- d0d924ab: Revert chagne to Type API
Changes:
- all: https://git.openjdk.java.net/panama-foreign/pull/21/files
- new: https://git.openjdk.java.net/panama-foreign/pull/21/files/73e2c418..d0d924ab
Webrevs:
- full: https://webrevs.openjdk.java.net/panama-foreign/21/webrev.02
- incr: https://webrevs.openjdk.java.net/panama-foreign/21/webrev.01-02
Stats: 20 lines in 1 file changed: 15 ins; 4 del; 1 mod
Patch: https://git.openjdk.java.net/panama-foreign/pull/21.diff
Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/21/head:pull/21
PR: https://git.openjdk.java.net/panama-foreign/pull/21
More information about the panama-dev
mailing list