[foreign-jextract] [Rev 01] RFR: 8239128: Macro defines constant pointers can crash VM via jextract API
Henry Jen
henryjen at openjdk.java.net
Fri Feb 21 20:40:41 UTC 2020
On Fri, 21 Feb 2020 01:16:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> Good job - I've left few minor comments, but the bulk of the work seems very solid.
Access cursor via CursorPosition can cause crash after close the Index. However, CursorPosition is only available internally, this is relative safe.
Alternatively, we can implement freeze on CursorPosition but that means we keep reference of all CursorPosition instances.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/21
More information about the panama-dev
mailing list