[foreign-jextract] RFR: 8249879: Split MemorySegment and MemoryAddress (jextract edition)

Athijegannathan Sundararajan sundar at openjdk.java.net
Tue Jul 28 03:44:54 UTC 2020


On Mon, 27 Jul 2020 18:17:18 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch fixes uses of memory segments and address following the big refactoring introduced by
> https://git.openjdk.java.net/panama-foreign/pull/260 from sources and tests.

Changes requested by sundar (Committer).

src/jdk.incubator.jextract/share/classes/jdk/internal/clang/Cursor.java line 337:

> 336:     }
> 337:
> 338:     public Stream<Cursor> children() {

This diff removes the callback cache fix for jextract performance. I believe this is unintentional merge artefact.

src/jdk.incubator.jextract/share/classes/jdk/internal/clang/Utils.java line 53:

> 52:     static int getLong(MemoryAddress addr) {
> 53:         return (int)LONG_VH.get(addr);
> 54:     }

Do we need this renaming wrapper? BTW most of this Utils class is just forwarding to MemoryAccess. Might as well use
MemoryAccess directly in callsties?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/267


More information about the panama-dev mailing list