[foreign-jextract] RFR: 8249879: Split MemorySegment and MemoryAddress (jextract edition)

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Jul 28 09:22:05 UTC 2020


On Tue, 28 Jul 2020 03:41:51 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> This patch fixes uses of memory segments and address following the big refactoring introduced by
>> https://git.openjdk.java.net/panama-foreign/pull/260 from sources and tests.
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/clang/Utils.java line 53:
> 
>> 52:     static int getLong(MemoryAddress addr) {
>> 53:         return (int)LONG_VH.get(addr);
>> 54:     }
> 
> Do we need this renaming wrapper? BTW most of this Utils class is just forwarding to MemoryAccess. Might as well use
> MemoryAccess directly in callsties?

We could, yes

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/267


More information about the panama-dev mailing list