[vector] Additional tests for ternary ops to bring the coverage up

Paul Sandoz paul.sandoz at oracle.com
Mon Jun 1 18:05:37 UTC 2020


In the unit header can we only add the ternary assert methods for FP?


I don’t see FP tests generated for the double broadcast case, but the kernels are present.


gen-template.sh
--

 156       if [ "x${kernel_smoke}" != "x" ]; then

Are you testing for empty string value? if so can you use the following?

  if [ -z "$kernel_smoke" ]; then


Paul.

> On May 29, 2020, at 4:48 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com> wrote:
> 
> Please find below a webrev which adds additional tests for Vector API ternary ops to bring the coverage up:
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part2/webrev.00/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part2/webrev.00/>
>  
> Also, the scripts have been modified to generate only smoke tests for named methods 
> where the equivalent lanewise method tests exists.
>  
> Best Regards,
> Sandhya



More information about the panama-dev mailing list