[vector] Additional tests for ternary ops to bring the coverage up

Viswanathan, Sandhya sandhya.viswanathan at intel.com
Tue Jun 2 00:34:45 UTC 2020


Hi Paul,

Thanks a lot for the feedback. Please find the updated webrev below:

http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part2/webrev.01

In this, I have updated the check for empty string value.
Also added ternary broadcast and double broadcast tests for float/double using the VectorOperators.FMA form.
Ternary assert methods are also used for bitwiseBlend in Integral tests, so I have retained the asserts methods.
Please let me know if I am missing something.

Best Regards,
Sandhya


From: Paul Sandoz <paul.sandoz at oracle.com>
Sent: Monday, June 01, 2020 11:06 AM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
Cc: panama-dev <panama-dev at openjdk.java.net>
Subject: Re: [vector] Additional tests for ternary ops to bring the coverage up

In the unit header can we only add the ternary assert methods for FP?


I don’t see FP tests generated for the double broadcast case, but the kernels are present.


gen-template.sh
--

 156       if [ "x${kernel_smoke}" != "x" ]; then
Are you testing for empty string value? if so can you use the following?

  if [ -z "$kernel_smoke" ]; then


Paul.


On May 29, 2020, at 4:48 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com>> wrote:

Please find below a webrev which adds additional tests for Vector API ternary ops to bring the coverage up:
http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part2/webrev.00/

Also, the scripts have been modified to generate only smoke tests for named methods
where the equivalent lanewise method tests exists.

Best Regards,
Sandhya



More information about the panama-dev mailing list