[foreign-abi] RFR: Merge openjdk/panama-foreign:foreign-memaccess
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Mar 13 10:32:34 UTC 2020
On Fri, 13 Mar 2020 00:28:28 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> Merge with foreign-memaccess
>
> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemorySegmentImpl.java line 63:
>
>> 62:
>> 63: final static int SMALL = ACQUIRE << 1;
>> 64: final static long NONCE = new Random().nextLong();
>
> Can there be more access mode in the future? We don't have any reserved space here. Although it's not likely to be an
> issue for the value to be different between version without persistence, it's better to keep same value.
> Personally I prefer to use form of 1 << n, instead of prev_value << 1.
I noted this as I was merging too, and I think we need to split the mask in two parts - public and private flags, and
mask the private flags when users ask for them.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/47
More information about the panama-dev
mailing list