[foreign-abi] RFR: Merge openjdk/panama-foreign:foreign-memaccess
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Mar 13 10:35:36 UTC 2020
On Fri, 13 Mar 2020 01:22:13 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> Merge with foreign-memaccess
>
> test/jdk/java/foreign/TestByteBuffer.java line 395:
>
>> 394: byteBuffer.get(); // should throw
>> 395: }
>> 396:
>
> I am a little confused with this change. What can we do with the returned ByteBuffer? Should we check the liveness in
> asByteBuffer()?
This change is just a merge change from the fix of JDK-8240874. The goal of that change is to determine a failure
caused by liveness. Before this change the code was (redundantly) treating asByteBuffer as an operation which could
only be performed on live segments. I've rectified that, but that means this test no longer threw the expected
exception, so I added another call which was triggering the failure (get).
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/47
More information about the panama-dev
mailing list