[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v2]
    Jorn Vernee 
    jvernee at openjdk.java.net
       
    Tue Sep 15 16:59:16 UTC 2020
    
    
  
On Tue, 15 Sep 2020 15:25:07 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments:
>>   - remove C_BOOL
>>   - CLinker javadoc changes
>>   - rename CLinker::getSystemLinker to CLinker::getInstance()
>
> Added some initial API comments - impl comments to follow soon
> 
> Also checked implementation - the changes are trivial and look good.
@mcimadamore & @PaulSandoz Thanks for the review, I've applied the suggested changes:
https://github.com/openjdk/panama-foreign/pull/327/commits/24f77111f5817c22decbeef5bee91218784158e9
I've also fixed a test that I noticed was no longer doing what is was supposed to (pre-existing to this PR).
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/327
    
    
More information about the panama-dev
mailing list