[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v2]

Jorn Vernee jvernee at openjdk.java.net
Tue Sep 15 16:59:17 UTC 2020


On Tue, 15 Sep 2020 16:26:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 99:
>> 
>>> 97:      * {@code permit}, {@code warn} or {@code debug} (the default value is set to {@code deny}).
>>> 98:      */
>>> 99:     static CLinker getSystemLinker() {
>> 
>> Should be `getSystemLinker` here? Also, the string passed to the restricted check doesn't match the name of the method
>
> Not sure what you mean here? The method is named getSystemLinker?
> 
> I've changed the message text.

Discussed offline: getSystemLinker implies too much that a particular system has One True Linker™. Changing this name
to getInstance().

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/327


More information about the panama-dev mailing list