[vectorIntrinsics+mask] RFR: 8264563: Add masked vector intrinsics for binary/store operations [v5]
Paul Sandoz
psandoz at openjdk.java.net
Thu Apr 15 16:26:24 UTC 2021
On Thu, 15 Apr 2021 02:49:59 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
> > I am tempted to have a template method for both non-mask and mask. Thus specialized code (that before calling the intrinsic) may be somewhat duplicated before calling `binaryMaskOp`, using a constant for the op -> lambda function, and passing in null or the mask value.
>
> Yeah, that's why I added the `lanewise0` and `lanewise0Template` methods.
I am suggesting to separate out templates for non-masked and masked, similar to the current pattern. That would result in some duplication for the special cases, but i think makes it easier to reason about in one place, rather than being somewhat spread out. Perhaps easier to explain as code. We should just iterate on the branch.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/57
More information about the panama-dev
mailing list