[vectorIntrinsics+mask] RFR: 8264563: Add masked vector intrinsics for binary/store operations [v5]

[Xiaohong Gong]

On Thu, 15 Apr 2021 16:22:45 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> > > I am tempted to have a template method for both non-mask and mask. Thus specialized code (that before calling the intrinsic) may be somewhat duplicated before calling `binaryMaskOp`, using a constant for the op -> lambda function, and passing in null or the mask value.
> > 
> > 
> > Yeah, that's why I added the `lanewise0` and `lanewise0Template` methods.
> 
> I am suggesting to separate out templates for non-masked and masked, similar to the current pattern. That would result in some duplication for the special cases, but i think makes it easier to reason about in one place, rather than being somewhat spread out. Perhaps easier to explain as code. We should just iterate on the branch.

Thanks for your more details! I think I misunderstood your point before. I will think about your suggestion. Thanks so much!

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/57