[vectorIntrinsics] RFR: 8265321: Add Rearrange nodes implementation for Arm SVE
Ningsheng Jian
njian at openjdk.java.net
Mon Apr 19 08:04:44 UTC 2021
On Mon, 19 Apr 2021 07:54:22 GMT, Wang Huang <whuang at openjdk.org> wrote:
> * I think that the comment is the node's comment (or rule's comment) instead of single instruction's comment. This rule is `rearrangeL` which means rearranging long type so I think that the comment should be `L` instead of `D`.
> * In `aarch64_neon.ad`, the comments are `` B``I``F``D `` and so on.
I assume you mean comment in format section. In aarch64_neon, some are S while some are F, but I don't think there's a need to generate two rules just for different format comments. If there's any, I would suggest to fix them as well.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/70
More information about the panama-dev
mailing list