[vectorIntrinsics] RFR: 8265321: Add Rearrange nodes implementation for Arm SVE

Wang Huang whuang at openjdk.java.net
Mon Apr 19 08:11:41 UTC 2021


On Mon, 19 Apr 2021 08:01:50 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

> > * I think that the comment is the node's comment (or rule's comment)  instead of single instruction's comment. This rule is `rearrangeL` which means rearranging long type so I think that the comment should be `L` instead of `D`.
> > * In `aarch64_neon.ad`, the comments are ` B`I`F`D `` and so on.
> 
> I assume you mean comment in format section. In aarch64_neon, some are S while some are F, but I don't think there's a need to generate two rules just for different format comments. If there's any, I would suggest to fix them as well.

Of course, in some case `L` and `D` can be zipped in one rule. However, in some case, `L` and `D` is difference. `D` is float type.  That is what I mentioned before `the comment is for the whole rule`.  In the comment, we should show the data type. ;-)

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/70


More information about the panama-dev mailing list